Skip to content

chore: Rename eventId in cartId for cart receipts#166

Merged
jacopocarlini merged 11 commits intomainfrom
rename-cart-id
Jan 30, 2026
Merged

chore: Rename eventId in cartId for cart receipts#166
jacopocarlini merged 11 commits intomainfrom
rename-cart-id

Conversation

@gioelemella
Copy link
Copy Markdown
Collaborator

@gioelemella gioelemella commented Jan 23, 2026

List of Changes

  • rename eventId in cartId in:
    • entity
    • log
    • client query
    • integration tests

Motivation and Context

Rename field to better reflects the real content

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Copy Markdown
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacopocarlini jacopocarlini merged commit 05c542a into main Jan 30, 2026
8 of 10 checks passed
@jacopocarlini jacopocarlini deleted the rename-cart-id branch January 30, 2026 10:59
@github-actions
Copy link
Copy Markdown

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants