Skip to content

fix: [PIDM-1733] Handle lower case fiscal codes#172

Open
gioelemella wants to merge 5 commits intomainfrom
PIDM-1733-handle-lower-case-fiscal-code
Open

fix: [PIDM-1733] Handle lower case fiscal codes#172
gioelemella wants to merge 5 commits intomainfrom
PIDM-1733-handle-lower-case-fiscal-code

Conversation

@gioelemella
Copy link
Copy Markdown
Collaborator

@gioelemella gioelemella commented Mar 26, 2026

List of Changes

  • updated fiscal code regex to match both upper and lower case
  • force fiscal codes to upper case before tokenization
  • avoid Pattern.compile() for each invocation
  • refactor code to reduce duplication

Motivation and Context

PIDM-1733
Allow receipt generation for biz events with lower case fiscal codes
Improve performance by precompiling Pattern

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions
Copy link
Copy Markdown

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant