Skip to content

Parse ignore arguments in flake8 to avoid issues with Atom#824

Merged
ccordoba12 merged 2 commits into
palantir:developfrom
thodnev:fix-769
Jun 30, 2020
Merged

Parse ignore arguments in flake8 to avoid issues with Atom#824
ccordoba12 merged 2 commits into
palantir:developfrom
thodnev:fix-769

Conversation

@thodnev

@thodnev thodnev commented Jun 25, 2020

Copy link
Copy Markdown
Contributor

PR addresses #769 as a temporary solution. Basic diagnostic was done here and a quickfix proposed here.

I did not have time to run the tests, hopefully CI will do it for us.
Also I don't know all the possible implications, maybe there are some more arguments need to be fixed.
I feel like these fixes need to be applied to Atom and its plugins. But, on the other hand having broken Atom used by millions of people is not good for PyLS too. Hope the Atom guys will manage to do their job solving the problem soon.

Fixes #769.

@palantirtech

Copy link
Copy Markdown
Member

Thanks for your interest in palantir/python-language-server, @thodnev! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@thodnev

thodnev commented Jun 25, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for your interest in palantir/python-language-server, @thodnev! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Alright, signed it. But guys, I just want you to know. These requirements are inadequate beyond belief. Having the MIT license and CONTRIBUTING is more than enough

@ccordoba12 ccordoba12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help @thodnev! I left a couple of minor comments, otherwise looks good.

Comment thread pyls/plugins/flake8_lint.py Outdated
Comment thread pyls/plugins/flake8_lint.py Outdated
@ccordoba12

Copy link
Copy Markdown
Contributor

Alright, signed it. But guys, I just want you to know. These requirements are inadequate beyond belief. Having the MIT license and CONTRIBUTING is more than enough

That was determined by the Palantir guys. I'm not affiliated with them in any way, I just help them to maintain this project.

@ccordoba12 ccordoba12 changed the title fix #769 aruments passed by Atom Parse ignore arguments in flake8 to avoid issues with Atom Jun 30, 2020
@thodnev

thodnev commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

@ccordoba12
Done. I don't know what are the commit policies of this project. So I've created one more commit with changes instead of rebasing.
You could squash merge if two commits is a problem

@ccordoba12 ccordoba12 added this to the 0.33.4 milestone Jun 30, 2020
@ccordoba12

Copy link
Copy Markdown
Contributor

Done. I don't know what are the commit policies of this project. So I've created one more commit with changes instead of rebasing.

That's fine. The policy here is to always squash PRs.

@ccordoba12 ccordoba12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @thodnev!

@ccordoba12 ccordoba12 merged commit a72704f into palantir:develop Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake8 and pyflakes plugins are not working on Atom at least on Linux (and maybe other OSes)

3 participants