This repository was archived by the owner on Jul 30, 2024. It is now read-only.
Closed
Conversation
* supporting two factor authentication: * Support Mail, SMS, or Google Authenticator second factor authentication. * Ability to change second factor authentication to existing users * Provide rescue mail in case of lost phone * update docs with two factor authentication changes * updating requirements, authors * adding two_factor test * improving tests coverage
van-ess0
force-pushed
the
develop
branch
10 times, most recently
from
0c3503f to
db1ba8d
Compare
…ne/flask-security into develop # Conflicts: # .gitignore # AUTHORS # docs/configuration.rst # docs/features.rst # docs/index.rst # docs/models.rst # flask_security/core.py # flask_security/forms.py # flask_security/signals.py # flask_security/views.py # requirements.txt # tests/conftest.py # tests/utils.py
jirikuncar
reviewed
Jun 28, 2018
| user_model_query = self.user_model.query | ||
| if hasattr(self.user_model, 'roles'): | ||
| from sqlalchemy.orm import joinedload | ||
| user_model_query = user_model_query.options(joinedload('roles')) |
Contributor
There was a problem hiding this comment.
How is the performance for loading roles solved right now?
Contributor
|
@van-ess0 can you please make sure the tests are passing? |
jasco
pushed a commit
to jasco/flask-security
that referenced
this pull request
Oct 3, 2023
Add documentation on how to properly subclass a form when using multiple inheritance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged PR #522
Solves #496