Skip to content

Fixes issue #447 #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidism merged 1 commit into from
May 18, 2018
Merged

Fixes issue #447 #1012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixes issue #447 
Fixes a ZeroDivisionError in ProgressBar.make_step when the first
arg passed to the first call of ProgressBar.update is 0.
  • Loading branch information
@rpgraham84 @davidism
rpgraham84 authored and davidism committed May 18, 2018
commit a112bb200a54727fa5f4d72e994ca6aaf8b4a553
11 changes: 10 additions & 1 deletion click/_termui_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,16 @@ def make_step(self, n_steps):
return

self.last_eta = time.time()
self.avg = self.avg[-6:] + [-(self.start - time.time()) / (self.pos)]

# self.avg is a rolling list of length <= 7 of steps where steps are
# defined as time elapsed divided by the total progress through
# self.length.
if self.pos:
step = (time.time() - self.start) / self.pos
else:
step = time.time() - self.start

self.avg = self.avg[-6:] + [step]

self.eta_known = self.length_known

Expand Down