Forward exception information to resources registered in a context

[Jazzinghen]

Updated Context.close and Context.__exit__ to allow forwarding exceptions to the __exit__ methods of the resources registered using Context.with_resource.

Added an extra function to handle both Context.close and Context.__exit__, called Context._close_with_exception_info that accepts all the parameters that __exit__ and moved the Content.close logic there.

Added relevant tests.

• fixes Exception information isn't passed through to context.with_resource managed resources #2447

[Jazzinghen]

I am not entirely sure what test is failing.

[davidism]

Failing test seems unrelated. Change looks good.

I'm not entirely certain whether this makes more sense as a bug fix (exit wasn't capturing exception) vs feature (exit now captures exception). It's technically a change in behavior, but the old behavior was incomplete. I think it's fine to target it at stable, just wanted to point out it's borderline.

[Jazzinghen]

Failing test seems unrelated. Change looks good.

I'm not entirely certain whether this makes more sense as a bug fix (exit wasn't capturing exception) vs feature (exit now captures exception). It's technically a change in behavior, but the old behavior was incomplete. I think it's fine to target it at stable, just wanted to point out it's borderline.

Ah, yes, this is something I was thinking about as well. The issue was marked as bug, but it's partly a bug, party a "new feature"?
I targeted stable only because the referenced issue was marked as Bug.

[Rowlando13]

@Jazzinghen I moved it to main so I can merge it and have it go out with 8.3.0. There were a lot of changes made to main that are not on stable. Can you check that changes still look right.

[Jazzinghen]

@Jazzinghen I moved it to main so I can merge it and have it go out with 8.3.0. There were a lot of changes made to main that are not on stable. Can you check that changes still look right.

I'll rebase it and check it in an hour!

[Jazzinghen]

Ok, I rebased the branch against main and tested it

[Rowlando13]

Also just caught it. Please add to changes.rst.

[Jazzinghen]

Also just caught it. Please add to changes.rst.

Done!
Is the style correct?

[Rowlando13]

Yes!