WIP: testing: runner: wrap stdin+stderr#951
Closed
blueyed wants to merge 2 commits intopallets:masterfrom
Closed
Conversation
This also helps with failures during testing, e.g. when using `pdb.set_tracce()` somewhere inside the runner's isolation - likely since it handles `write` already. Ref: pallets#824
This was referenced Mar 27, 2018
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also helps with failures during testing, e.g. when using
pdb.set_tracce()somewhere inside the runner's isolation - likelysince it handles
writealready.Ref: #824