format commands normalize format -> remove short_help option#998
Closed
fdavis wants to merge 5 commits intopallets:masterfrom
Closed
format commands normalize format -> remove short_help option#998fdavis wants to merge 5 commits intopallets:masterfrom
fdavis wants to merge 5 commits intopallets:masterfrom
Conversation
to address pallets#936 and related issues it seems cleaner to remove this function and let the formatter print the command block
Contributor
Author
Contributor
Author
|
closing in favor of #1002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The short_help option is only used in the commands view and seems to have caused some confusion about its interaction with the actual help for a command.
I propose we deprecate it and allow the format_commands to handle this