Ensure that rules without strict slashes match paths with slashes#2468
Merged
davidism merged 2 commits intopallets:2.2.xfrom Jul 25, 2022
Merged
Ensure that rules without strict slashes match paths with slashes#2468davidism merged 2 commits intopallets:2.2.xfrom
davidism merged 2 commits intopallets:2.2.xfrom
Conversation
davidism
reviewed
Jul 25, 2022
A rule defined as `/path` with strict-slashes == False should match a path `/path/` but only if there isn't a rule that directly matches `/path/`. This restores the previous 2.2.0 behaviour.
Member
Author
|
Does the ValidationError change need a changelog? |
Member
|
Sure, might as well. |
This matches the documented import path.
This was
linked to
issues
Jul 25, 2022
This was referenced Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rule defined as
/pathwith strict-slashes == False should match apath
/path/but only if there isn't a rule that directly matches/path/. This restores the previous 2.2.0 behaviour.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.This closes #2467.
This closes #2465.