Bugfix the calculation of weighting based on static parts#2472
Merged
davidism merged 1 commit intopallets:2.2.xfrom Jul 27, 2022
Merged
Bugfix the calculation of weighting based on static parts#2472davidism merged 1 commit intopallets:2.2.xfrom
davidism merged 1 commit intopallets:2.2.xfrom
Conversation
Only static parts that are more than a `/` should count towards the weighting, as they influence the part for matching. This prevents `/<path:p>/<a>/<b>` matching before `/<path:p>/b` as only the latter rule should have a static weighting as it is the only rule that has a static part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2471
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.