Skip to content

TYP: enable reportUnknownVariableType #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dr-Irv merged 11 commits into from
Dec 26, 2025
Merged

TYP: enable reportUnknownVariableType #1522

Dr-Irv merged 11 commits into from
Dec 26, 2025

Conversation

@cmp0xff
Copy link
Contributor

@cmp0xff cmp0xff commented Dec 3, 2025 •
edited
Loading

Towards #1171

  • In the stub files, the additions only include pyright: ignore[reportUnknownVariableType] for third party Python modules
  • In the tests, added pyright: ignore[reportUnknownVariableType]'s are from
    • Third party Python modules
    • Dummy variables in invalid tests (e.g. _1 = "a" / 2 # pyright: ignore[reportUnknownVariableType])

cmp0xff
cmp0xff commented Dec 3, 2025
View reviewed changes
cmp0xff
cmp0xff commented Dec 3, 2025
View reviewed changes
@cmp0xff cmp0xff force-pushed the feature/reportUnknownVariableType branch from d056f30 to 65e6724 Compare December 3, 2025 21:42
This was referenced Dec 3, 2025
Merged
Merged
@cmp0xff cmp0xff force-pushed the feature/reportUnknownVariableType branch from 65e6724 to 14f04e0 Compare December 4, 2025 13:35
@cmp0xff
Copy link
Contributor Author

cmp0xff commented Dec 4, 2025

/pyright_strict

@cmp0xff cmp0xff mentioned this pull request Dec 4, 2025
Merged
@cmp0xff cmp0xff force-pushed the feature/reportUnknownVariableType branch from 14f04e0 to 7a945d2 Compare December 6, 2025 20:46
@cmp0xff cmp0xff mentioned this pull request Dec 8, 2025
Merged
@cmp0xff cmp0xff force-pushed the feature/reportUnknownVariableType branch 3 times, most recently from fdaa258 to 4928823 Compare December 8, 2025 22:36
@cmp0xff cmp0xff mentioned this pull request Dec 9, 2025
Merged
@cmp0xff cmp0xff force-pushed the feature/reportUnknownVariableType branch 2 times, most recently from d53df7d to b610573 Compare December 11, 2025 08:20
@cmp0xff cmp0xff mentioned this pull request Dec 11, 2025
Merged
1 task
@cmp0xff cmp0xff force-pushed the feature/reportUnknownVariableType branch 2 times, most recently from c3d69db to db74e6a Compare December 15, 2025 08:20
@cmp0xff cmp0xff changed the title TYP: enable reportUnknownVariableType TYP: enable reportUnknownVariableType Dec 15, 2025
@cmp0xff cmp0xff force-pushed the feature/reportUnknownVariableType branch 5 times, most recently from cf09bf8 to cb064e9 Compare December 16, 2025 21:03
@cmp0xff cmp0xff force-pushed the feature/reportUnknownVariableType branch 2 times, most recently from 5067713 to d35645a Compare December 24, 2025 15:05
@cmp0xff cmp0xff force-pushed the feature/reportUnknownVariableType branch from d35645a to cc263cd Compare December 24, 2025 15:09
@cmp0xff cmp0xff requested a review from Dr-Irv December 24, 2025 15:13
@cmp0xff cmp0xff marked this pull request as ready for review December 24, 2025 15:13
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 24, 2025

/pyright_strict

1 similar comment
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 24, 2025

/pyright_strict

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 24, 2025

Now with pyright_strict, we have the following left to consider:

reportPrivateUsage             57
reportUnknownArgumentType      63
reportUnknownMemberType       101
reportMissingParameterType    122
reportUnknownParameterType    204

Dr-Irv
Dr-Irv requested changes Dec 24, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

@cmp0xff cmp0xff requested a review from Dr-Irv December 24, 2025 22:51
Dr-Irv
Dr-Irv reviewed Dec 24, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some open issues

@cmp0xff cmp0xff requested a review from Dr-Irv December 25, 2025 12:41
Dr-Irv
Dr-Irv requested changes Dec 26, 2025
View reviewed changes
@cmp0xff cmp0xff requested a review from Dr-Irv December 26, 2025 08:34
Dr-Irv
Dr-Irv reviewed Dec 26, 2025
View reviewed changes
tests/extension/decimal/array.py
self, ufunc: np.ufunc, method: str, *inputs: Any, **kwargs: Any
) -> arraylike.dispatch_ufunc_with_out: # type: ignore[name-defined] # pyright: ignore[reportAttributeAccessIssue]
#
) -> Any:
Copy link
Collaborator

@Dr-Irv Dr-Irv Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the typing here was wrong in the first place. It's wrong in the pandas source.

Dr-Irv
Dr-Irv approved these changes Dec 26, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cmp0xff

@Dr-Irv Dr-Irv merged commit 4018ebc into pandas-dev:main Dec 26, 2025
16 checks passed
@cmp0xff cmp0xff deleted the feature/reportUnknownVariableType branch December 27, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmp0xff @Dr-Irv