IO benchmarking is ready to merge#44
Merged
Merged
Conversation
Co-Authored-By: Anderson Banihirwe <axbanihirwe@ualr.edu>
Co-Authored-By: Kevin Paul <kpaul@ucar.edu>
Co-Authored-By: Kevin Paul <kpaul@ucar.edu>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kmpaul
approved these changes
Feb 2, 2021
Collaborator
kmpaul
left a comment
kmpaul
left a comment
There was a problem hiding this comment.
There are a lot of changes, so I'm not sure I can verify all of the changes, but I think this looks good. Because the changes are so large, and the checks currently pass, I would recommend that we merge this and then deal will smaller, individual modifications in separate PRs.
This was referenced Feb 2, 2021
Collaborator
Author
|
@kmpaul, great, thanks!
…On Tue, Feb 2, 2021 at 9:59 AM Kevin Paul ***@***.***> wrote:
Merged #44 <#44> into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAPEFCPBTOANR6YGKW3Z43S5AVQVANCNFSM4WZFYG6A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have developed Pangeo IO benchmarking based on this repo, and output the package version and its critical dependency versions to csv files, fixed the repeated outputs to csv problem.