Update ContentSerializer Settings to allow data POST back to AutoTask API#3
Open
MacgyverH wants to merge 7 commits into
Open
Update ContentSerializer Settings to allow data POST back to AutoTask API#3MacgyverH wants to merge 7 commits into
MacgyverH wants to merge 7 commits into
Conversation
- Replace System.Text.Json with Newtonsoft.Json for serialization - Update RefitSettings to use NewtonsoftJsonContentSerializer - Adjust JSON settings for null value handling and property naming
- Added Refit.Newtonsoft.Json package to AutoTask.Psa.Api.csproj - Added Refit.Newtonsoft.Json package version to Directory.Packages.props
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 1 medium |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
- Removed the using directive for Refit.Newtonsoft.Json
- Replace System.Text.Json with Newtonsoft.Json for serialization - Update RefitSettings to use NewtonsoftJsonContentSerializer - Adjust JSON settings for null value handling and property naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting to implement this API Library, I ran into some issues when attempting to submit POST requests back to AutoTask, after some further investigation, I found that null fields were being sent to AutoTask, which was resulting in a 500 Server error.
This change seems to fix this issue.