Don't try to write timestamp attributes just because the method exists; only write it if it is a real attribute.#280
Merged
batter merged 1 commit intopaper-trail-gem:masterfrom Oct 3, 2013
Conversation
…s; only write it if it is a real attribute. This resolves this error you would get if you defined a created_on method (virtual attribute) in your model, for example: DEPRECATION WARNING: You're trying to create an attribute `created_on'. Writing arbitrary attributes on a model is deprecated. Please just use `attr_writer` etc.
Collaborator
|
Cheers! |
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves this error you would get if you defined a created_on method (virtual attribute) in
your model, for example:
DEPRECATION WARNING: You're trying to create an attribute
created_on'. Writing arbitrary attributes on a model is deprecated. Please just useattr_writer` etc.