Skip to content

paper_trail for ActionController::API#313

Closed
ghalley wants to merge 1 commit intopaper-trail-gem:masterfrom
ghalley:master
Closed

paper_trail for ActionController::API#313
ghalley wants to merge 1 commit intopaper-trail-gem:masterfrom
ghalley:master

Conversation

@ghalley
Copy link
Copy Markdown
Contributor

@ghalley ghalley commented Jan 8, 2014

Including this to be able to use info_for_paper_trail via :set_paper_trail_controller_info when using ActionController::API.

@batter
Copy link
Copy Markdown
Collaborator

batter commented Jan 8, 2014

Thanks for the PR, good thought, I wasn't aware of the rails-api gem until now. Question: Have you tested this?

@ghalley
Copy link
Copy Markdown
Contributor Author

ghalley commented Jan 8, 2014

Ran rake test and rake spec with green across the board.

@batter
Copy link
Copy Markdown
Collaborator

batter commented Jan 8, 2014

No, I mean have you tested to see if this will work with an ActionController::API instance?

@ghalley
Copy link
Copy Markdown
Contributor Author

ghalley commented Jan 8, 2014

Absolutely! Ran into this issue with an app I'm building using ActionController::API. I pointed my gemfile to grab my fork of paper_trail and it's working perfectly now.

@batter batter closed this in 802b7d4 Jan 8, 2014
@batter
Copy link
Copy Markdown
Collaborator

batter commented Jan 8, 2014

Cheers! Just wanted to make sure that this hook would trigger properly.

@ghalley
Copy link
Copy Markdown
Contributor Author

ghalley commented Jan 8, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants