Allows the definition of a customized whodunnit in a small scope

[lucasas]

It's very useful when you want to define who is responsible to change some object and don't considering the global scope or request scope.

[seanlinsley]

It seems like this would make more sense instead of having whodunnit and _whodunnit

def whodunnit(whodunnit = PaperTrail.whodunnit)
  @whodunnit = whodunnit
  yield if block_given?
end

[lucasas]

Hi @seanlinsley, what about the case where I don't want to use my_object.whodunnit?

[lucasas]

Did you have plans to merge this?

[batter]

@lucasas - Yes. After reviewing the PR a little more closely just now I'm thinking it probably makes more sense to drop the instance variable store and only allow this method to be called with a block argument to prevent confusion.

As in:

PaperTrail.whodunnit = 'Andy Stewart'

widget = Widget.create!
widget.versions.last.whodunnit # 'Andy Stewart'

# This will work
widget.whodunnit 'Lucas Souza' do
  widget.update_attributes :name => 'Wibble'
end

widget.versions.last.whodunnit # 'Lucas Souza'

# This won't
Widget.whodunnit = 'Lucas Souza' # Throws Error

I just think trying to store the value as an instance variable could create some confusion both with usage and with code readability in terms of adding an additional level of complexity. Does that make sense?

[lucasas]

Hi @batter, thanks for accept my PR. I think make sense your changes.