Fallback in user_for_paper_trail to accept current_user returning a string

[shweelan]

3.0.1 introduced a breaking changes to how current_user works. This is a workaround for backward compatibility.

[batter]

It's shouldn't be a breaking change because you can always override the user_for_paper_trail method on a per-controller basis (or globally by defining it on your ApplicationController) if you want it to behave differently. Please see #316 for context as to why the change was made.

This seems reasonable I suppose, but what is your current_user object returning? The reason this change was made was because most people have an User model instance or something to that effect being returned from their current_user helper. You just have a String?

[shweelan]

I have multiple application toolbox, they are commonly using the current_user function which returning only string not a model object, because I am using LDAP active directory credentials for users login, that's why I don't have users model. my changes to paper_trail gem will provide more flexibility to use string as well as model object.

[batter]

So I had to switch up the invocation of the try method to accommodate the change in behavior between ActiveSupport 3 & 4, but I merged this in. Thanks for the PR.

I still would argue it's not a breaking change, because the user_for_paper_trail method is designed to be overridden by a user, but this will hopefully make that helper method work a little better out of the box for most users.

[shweelan]

Hi,
thanks for your kind action.

when I first used paper trail, I felt lucky to get my current_user to the revisions log, with no need for changing any line in my code. That's why I said its breaking change cause when I made bundle update the app crashed.