Check for RSpec::Core before loading RSpec helpers#398
Merged
batter merged 1 commit intopaper-trail-gem:masterfrom Jul 18, 2014
Merged
Check for RSpec::Core before loading RSpec helpers#398batter merged 1 commit intopaper-trail-gem:masterfrom
batter merged 1 commit intopaper-trail-gem:masterfrom
Conversation
batter
added a commit
that referenced
this pull request
Jul 18, 2014
Collaborator
|
Cheers! |
Contributor
Author
|
No problem - great work Ben! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paper_trailcurrently breaks during initialisation wheneverrspec-mocksis used with another test framework (eg: Minitest).This is a minor tweak so that
paper_trailchecks that theRSpec::Coremodule is defined before trying to load the RSpec test helpers (RSpec::Corewill be defined if either therspecgem or it's dependencyrspec-coreis loaded).