Fixed: the redefined methods problem

[proAlexandr]

I have tried to fix problem with redefined attribute methods in a model.
Now, I get problem if I redefine an attribute getter and setter. For example:

def price=(value)
  write_attribute(:price, value / 60)
end

def price
  read_attribute(:price) * 60 
end

Version model use new getter (price) for store a value, but when it restore the value, version don't use my new setter.

[batter]

You shouldn't need the custom setter to be invoked because the getter will read the value out properly. We store the "unserialized" value, and thus that's what gets assigned to the model when reifying, which seems like it should be correct unless I'm mistaken.

If I'm wrong then please provide a test demonstrating what you're trying to address here. As you can see, we already have a test in the suite mimicking the type of thing you're referring to, and it passes with the current master but fails with your "patch" here..

[batter]

Here is an expanded view of all the code surrounding those tests / when write_attribute was implemented in the first place

[proAlexandr]

I get a wrong behaviour when I use multilang-hstore
It uses overwriting default accessors and serialization simultaneously.
I am going to write a test soon.

[batter]

@proAlexandr, here is my proposed fix: f5f310b

It's on the vattr_support branch, so can you try bundling from that branch and seeing if it fixes your test case please?

[batter]

Thanks for the PR, and for bringing this to my attention. I made a slight modification so the reify method now handles both normal ActiveRecord attributes and custom defined virtual attributes and setters properly.