Skip to content

Make Config.enabled backed by a thread variable #539#541

Merged
batter merged 1 commit intopaper-trail-gem:masterfrom
stormsilver:thread-safe-disabled
Jun 8, 2015
Merged

Make Config.enabled backed by a thread variable #539#541
batter merged 1 commit intopaper-trail-gem:masterfrom
stormsilver:thread-safe-disabled

Conversation

@stormsilver
Copy link
Copy Markdown
Contributor

No description provided.

@batter
Copy link
Copy Markdown
Collaborator

batter commented May 28, 2015

Perhaps it makes more sense to just store it in the PaperTrail#paper_trail_store, which is backed by the thread-safe RequestStore library?

@stormsilver
Copy link
Copy Markdown
Contributor Author

@batter I looked at that initially. I haven't seen RequestStore before but it looked like it really wanted a request to work properly. I'll take another swing through it and see about using the paper_trail_store.

@stormsilver stormsilver force-pushed the thread-safe-disabled branch from 1ec7baa to 71faed3 Compare June 3, 2015 14:28
@stormsilver
Copy link
Copy Markdown
Contributor Author

@batter Yep, as I looked into RequestStore it's obviously just a wrapper around sticking a hash with a name onto the thread. I replaced Thread with PaperTrail.paper_trail_store and it seemed to work okay - let me know if that's what you were thinking or not.

@batter batter added this to the 4.0.0 milestone Jun 8, 2015
batter added a commit that referenced this pull request Jun 8, 2015
Make Config.enabled backed by a thread variable #539
@batter batter merged commit a158772 into paper-trail-gem:master Jun 8, 2015
batter added a commit that referenced this pull request Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants