Log errors when versions can't be created

[md5]

As discussed in #807, this PR updates record_update and record_destroy to log a warning listing all validation errors when a Version instance cannot be saved. It does not update record_create since that calls Version.create! instead of Version.create and should raise an error for any validation failures.

Due to Rubocop complaining, I have also slightly refactored has_paper_trail.rb to fix some of the complaints. There is still a complaint about the InstanceMethods module being too many lines, but I didn't see any easy way to reduce the line count of these changes without going too far off topic and into the weeds.

[jaredbeck]

There is still a complaint about the InstanceMethods module being too many lines ..

Just bump up the number in rubocop_todo.yml .. it's a fight for another day :)

[jaredbeck]

I find this conditional hard to read. I'd prefer:

if version.errors.any?
  log_version_errors(version, :update)
else
  update_transaction_id(version)
  # etc.

If rubocop complains about method complexity, just bump up the numbers; it's a fight for another day.

[md5]

That's what I had originally until RuboCop complained about AbcSize. I've changed it back, though subsequent edits seem to have removed the need to bump AbcSize.

[md5]

I've refactored and bumped the Metrics/ModuleLength limit in .rubycop_todo.yml 👍

[jaredbeck]

Thanks Mike!

[md5]

🤘