fix: move empty-diff guard before git commit in kubernetes.yaml#109
Closed
jmpalomares wants to merge 2 commits into
Closed
fix: move empty-diff guard before git commit in kubernetes.yaml#109jmpalomares wants to merge 2 commits into
jmpalomares wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #82 added an empty-diff guard to the commit job in
kubernetes.yaml, but placed it after git commit. After a commit, the staged index is clean by definition, sogit diff --cached --quietalways passes and the script exits beforegit push origin main. Every consumer of@v8has been silently creating the bot commit on the runner and throwing it away — Actions runs are green but origin/main never updates and the chart never bumps.This moves the guard to right after git add ., where it actually short-circuits when there is nothing new to deploy, and removes it from the else branch where it was a no-op. Applies to both the env-tag and regular main paths.
PR #81 removed the original guard (which had been correctly placed before git commit).
PR #82 re-added it, but in the else branch after the commit — where the check is always true.