Skip to content

Clean up leftover submodules/watr references#1265

Merged
nprt merged 1 commit into
mainfrom
ndk/cleanup-watr-leftovers
May 21, 2026
Merged

Clean up leftover submodules/watr references#1265
nprt merged 1 commit into
mainfrom
ndk/cleanup-watr-leftovers

Conversation

@x3c41a
Copy link
Copy Markdown
Contributor

@x3c41a x3c41a commented May 20, 2026

Summary

  • Delete the submodules/watr gitlink and the matching polkadot/parachain/watr/chainspec.json symlink

Why

#1101 removed the [submodule "submodules/watr"] entry from .gitmodules (because the upstream Watr-Protocol/watr.git repo is no longer accessible) but left the submodules/watr gitlink in the tree and the symlink that pointed into it. The resulting inconsistency makes actions/checkout with submodules: true error out:

fatal: No url found for submodule path 'submodules/watr' in .gitmodules

This currently fails CI on every PR in the repo on every branch.

#1101 dropped the watr entry from .gitmodules but left the gitlink at
submodules/watr and a dangling symlink at polkadot/parachain/watr.
That inconsistency causes 'fatal: No url found for submodule path
submodules/watr' on every checkout with submodules: true, failing CI
on every PR.
@x3c41a x3c41a requested a review from bkontur May 20, 2026 14:38
@bkontur bkontur enabled auto-merge (squash) May 20, 2026 20:43
@bkontur
Copy link
Copy Markdown
Contributor

bkontur commented May 20, 2026

@nprt could you please review/merge?

@nprt nprt disabled auto-merge May 21, 2026 08:10
@nprt nprt merged commit 1dae6c1 into main May 21, 2026
5 of 6 checks passed
@nprt nprt deleted the ndk/cleanup-watr-leftovers branch May 21, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants