Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Asset Transaction Payment#488

Merged
apopiak merged 75 commits into
masterfrom
apopiak/asset-tx-payment
Oct 11, 2021
Merged

Asset Transaction Payment#488
apopiak merged 75 commits into
masterfrom
apopiak/asset-tx-payment

Conversation

@apopiak
Copy link
Copy Markdown
Contributor

@apopiak apopiak commented Jun 10, 2021 •
edited
Loading

Add a pallet to allow for transaction payment in assets.

The asset-tx-payment pallet wraps FRAME's transaction-payment pallet and either pays the fees in the native currency if the asset id is set to None or in the specified asset.

Depends on:

Closes #505

Todos:

  • FungiblesAdapter

@apopiak apopiak requested a review from gavofyork June 10, 2021 16:08
This was referenced Jun 10, 2021
Merged
Closed
@apopiak
Copy link
Copy Markdown
Contributor Author

apopiak commented Jun 17, 2021

@jacogr We'll need a different SignedExtra for the transactions here.

@apopiak apopiak mentioned this pull request Jun 17, 2021
Merged
@apopiak apopiak marked this pull request as ready for review June 17, 2021 14:48
@freehere107 freehere107 mentioned this pull request Jun 21, 2021
Closed
@apopiak
Copy link
Copy Markdown
Contributor Author

apopiak commented Oct 4, 2021

I would like to merge this PR.
Only open conversations are #488 (comment) and #488 (comment) and for both I tend towards staying with the status quo of the PR.

@apopiak apopiak requested a review from bkchr October 5, 2021 13:02
@apopiak
Copy link
Copy Markdown
Contributor Author

apopiak commented Oct 5, 2021

@bkchr Any objections to merging this?

bkchr
bkchr reviewed Oct 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see it looks good.

Comment thread polkadot-parachains/parachains-common/src/impls.rs Outdated
Comment thread pallets/asset-tx-payment/src/lib.rs Outdated
Comment thread pallets/asset-tx-payment/src/payment.rs Outdated
@apopiak
Copy link
Copy Markdown
Contributor Author

apopiak commented Oct 7, 2021

Note: Will require spec version and transaction bumps when upstreaming Statemine v4 release

apopiak
apopiak commented Oct 7, 2021
View reviewed changes
Comment thread pallets/asset-tx-payment/src/tests.rs Outdated
@apopiak apopiak merged commit 3520acc into master Oct 11, 2021
@apopiak apopiak deleted the apopiak/asset-tx-payment branch October 11, 2021 09:57
This was referenced Oct 13, 2021
Open
Closed
@github-actions github-actions Bot mentioned this pull request Nov 2, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gavofyork gavofyork Awaiting requested review from gavofyork

@kianenigma kianenigma Awaiting requested review from kianenigma

3 more reviewers

@tomusdrw tomusdrw tomusdrw left review comments

@bkchr bkchr bkchr left review comments

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T7-system_parachains This PR/Issue is related to System Parachains.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accept Transaction Fees in Assets

4 participants

@apopiak @tomusdrw @shawntabrizi @bkchr