fix(webrtc): support different ordering of protobuf flags#577
Open
gab8i wants to merge 1 commit into
Open
Conversation
lexnv
reviewed
May 14, 2026
| let mut state = self.state.lock(); | ||
|
|
||
| // Shutdown process has alredy started or it already reached | ||
| // conclusion. Sending already stopped. |
lexnv
reviewed
May 14, 2026
| // already sent FIN and are waiting for FIN_ACK. This shouldn't happen | ||
| // with correct AsyncWrite usage (&mut self), but provides defense in depth. | ||
| // | ||
| // State::SendClosed: peer sent STOP_SENDING (no longer accepting our |
Collaborator
There was a problem hiding this comment.
Nice! Could we add a few more tests for the fixes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.