Skip to content

impl compact<()> for MaxEncodedLen#516

Merged
bkchr merged 1 commit intomasterfrom
pg/add_compact_unit_type
Sep 9, 2023
Merged

impl compact<()> for MaxEncodedLen#516
bkchr merged 1 commit intomasterfrom
pg/add_compact_unit_type

Conversation

@pgherveou
Copy link
Copy Markdown
Contributor

@pgherveou pgherveou commented Sep 8, 2023

Third time's the charm
Adding impl compact<()> for MaxEncodedLen to get polkadot-sdk to compile with this branch

see paritytech/polkadot-sdk#1424

@pgherveou
Copy link
Copy Markdown
Contributor Author

I think that one is necessary for all tests to pass on polkadot-sdk, will run CI against it to make sure this time

@pgherveou pgherveou marked this pull request as ready for review September 8, 2023 11:55
@pgherveou
Copy link
Copy Markdown
Contributor Author

Tests seems to pass on polkadot-sdk with this branch
paritytech/polkadot-sdk#1424

It's just failing these 3, but I believe that might be related to network access to github

@paritytech-ci
continuous-integration/gitlab-build-push-image-malus — {"build_allow_failure":false}
[Details](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/builds/3618748)
@paritytech-ci
continuous-integration/gitlab-build-push-image-polkadot-debug — {"build_allow_failure":false}
[Details](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/builds/3618739)
@paritytech-ci
continuous-integration/gitlab-test-frame-ui — {"build_allow_failure":false}
Required
[Details](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/builds/3617838)
@paritytech-ci
continuous-integration/gitlab-test-linux-stable 3/3 — {"build_allow_failure":false}

@pgherveou pgherveou requested review from bkchr and ggwpez September 8, 2023 13:43
@KiChjang
Copy link
Copy Markdown
Contributor

KiChjang commented Sep 9, 2023

It would also be nice to try and figure out where we use Compact<()>, because at first sight, it looks very weird to see that we're trying to compactify a ZST.

@bkchr bkchr merged commit 37a6e76 into master Sep 9, 2023
@bkchr bkchr deleted the pg/add_compact_unit_type branch September 9, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants