Conversation
Contributor
Author
|
I think that one is necessary for all tests to pass on polkadot-sdk, will run CI against it to make sure this time |
Contributor
Author
|
Tests seems to pass on polkadot-sdk with this branch It's just failing these 3, but I believe that might be related to network access to github |
KiChjang
approved these changes
Sep 9, 2023
Contributor
|
It would also be nice to try and figure out where we use |
bkchr
approved these changes
Sep 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third time's the charm
Adding
impl compact<()> for MaxEncodedLento get polkadot-sdk to compile with this branchsee paritytech/polkadot-sdk#1424