Merged
Conversation
Contributor
Author
|
Related to #688 , I tested |
gui1117
previously approved these changes
Feb 5, 2025
Contributor
gui1117
left a comment
There was a problem hiding this comment.
We can update the CHANGELOG, I forgot to put the 653 into the changelog in the past:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index fa565d5..c15edb7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,9 +5,15 @@ All notable changes to this crate are documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this crate adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
-## Unreleased
+## 3.7.4 - 2025-02-05
-### [3.7.3] - 2025-01-30
+### Added
+
+- Disallow duplicate indexes using constant evaluation ([#653](https://github.com/paritytech/parity-scale-codec/pull/653))
+
+## [3.7.3] - 2025-01-30
+
+### Added
- Fix added bounds in `Encode` and other derive macros. ([#689](https://github.com/paritytech/parity-scale-codec/pull/689))
Merged
Contributor
|
Note that if we run cargo test we can some error: people will have to update |
I am not sure yet. People will complain that frame-support doesn't compile. Maybe we should update frame-support first.
Contributor
Author
Done |
Contributor
Author
Yes, you're right. We should patch frame-support probably |
Contributor
Author
Contributor
Author
gui1117
approved these changes
Feb 7, 2025
Contributor
gui1117
left a comment
There was a problem hiding this comment.
I also checked compilation of open-runtime-module-library.
Looks good to me.
This was referenced Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.