OpenGov in Westend and Rococo by al3mart · Pull Request #1177 · paritytech/polkadot-sdk

al3mart · 2023-08-25T16:10:57Z

Migrating PR from the archived polkadot repo

As per paritytech/polkadot#7272 (comment), the changes in this MR include the following pallets into [x] Rococo and [x] Westend runtimes:

pallet_conviction_voting
pallet_referenda
pallet_ranked_collective
pallet_custom_origins
pallet_whitelist

And only for westend-runtime:

pallet_treasury

Following Kusama runtime config as a baseline.

Benchmarking of the following pallets done for Rococo and Westend:

pallet_conviction_voting
pallet_referenda
pallet_ranked_collective
pallet_whitelist

And only for Westend:

pallet_treasury

Removed Gov1 from Rococo as in paritytech/polkadot#6701

al3mart · 2023-08-25T16:11:34Z

All the last comments have been addressed and these changes should be ready for a final review

gilescope · 2023-09-04T08:50:28Z

I think this is an important PR for several reasons:

It enables people to test governance proposals without having to send them to try them first time for real on a financial network.
It means the runtime code differences between production and test runtimes are minimised meaning that important differences are less likely to be missed.

al3mart · 2023-09-04T09:58:28Z

@gilescope thanks for the feedback and contributions, I would invite you to leave a review in case you have time for it just for being a bit closer to unlock that merge :)

@muharem @joepetrowski @mordamax I believe this PR is in good shape and we could try to merge it if there is no further changes required

polkadot/runtime/rococo/src/governance/tracks.rs

polkadot/runtime/westend/constants/src/lib.rs

al3mart · 2023-09-07T16:28:04Z

Comments addressed.

I have reduce the periods duration to keep everything in the range of the minutes. Maintaining the differences between tracks and prepare, decision, confirmation and min_enactment periods to still keep some coherence with the spans of time that are on both production networks.

chevdor

Great to test but also nice for people to test those features out to learn.

It would be good to ping @devops-parity and the sudos of those chains to ensure they are aware of the risks and that a recovery plan is drafted in case of an annoyance sneaks in to the short voting periods.

liamaharon

While we're at it, we should probably clean up the Gov V1 storage as was done in paritytech/polkadot#7314

mordamax · 2023-09-18T13:55:04Z

@liamaharon @al3mart could this cleanup be done in a separate PR?
we really need this to be merged asap :)

Thanks!

paritytech-cicd-pr · 2023-09-26T12:52:42Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: check-tracing
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3798101

al3mart · 2023-09-27T15:04:12Z

As a heads up I checked the migrations with try-runtime and got the following result for Rococo runtime
INFO try-runtime::cli] Consumed ref_time: 2.053575s (102.68% of max 2s)

* master: (61 commits) OpenGov in Westend and Rococo (#1177) Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720) Migrate polkadot-primitives to v6 (#1543) genesis-builder: implemented for all runtimes (#1492) `BlockId` removal: `tx-pool` refactor (#1678) Bump directories from 4.0.1 to 5.0.1 (#1656) Allow debug_assertions in short-benchmarks CI job (#1711) chainHead/storage: Fix storage iteration using the query key (#1665) Implement more useful traits in `Slot` type (#1595) Make downloads in parallel and give more time to complete (#1699) Bump actions/checkout from 4.0.0 to 4.1.0 (#1688) contracts: Fix incorrect storage alias in mirgration (#1687) Fix documentation about justification and `finalized == true` requirement (#1607) tweak pallet macro (genesis_config etc) to cater for RA users as well. (#1689) Uncoupling pallet-xcm from frame-system's RuntimeCall (#1684) Bump aes-gcm from 0.10.2 to 0.10.3 (#1681) docs / Update PR template to reflect monorepo (#1674) update contributing guide and ui-tests scripts (#1668) pallet epm: add `TrimmingStatus` to the mined solution (#1659) Update HRMP pallet benchmarking to use benchmarks v2 (#1676) ...

* tsv-disabling-node-side: (69 commits) runtime-api: cleanup after v7 stabilization (#1729) Move requests-responses and polling from `ChainSync` to `SyncingEngine` (#1650) Add custom error message for `StorageNoopGuard` (#1727) Clarify docs cargo fmt add a CAVEAT comment implement disabled_validators correctly remove unnecessary hash string (#1722) OpenGov in Westend and Rococo (#1177) Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720) Migrate polkadot-primitives to v6 (#1543) genesis-builder: implemented for all runtimes (#1492) `BlockId` removal: `tx-pool` refactor (#1678) Bump directories from 4.0.1 to 5.0.1 (#1656) Allow debug_assertions in short-benchmarks CI job (#1711) chainHead/storage: Fix storage iteration using the query key (#1665) Implement more useful traits in `Slot` type (#1595) Make downloads in parallel and give more time to complete (#1699) Bump actions/checkout from 4.0.0 to 4.1.0 (#1688) contracts: Fix incorrect storage alias in mirgration (#1687) ...

Following [polkadot#7314](paritytech/polkadot#7314) and after merging #1177 this PR solves #1618 The following is a summary of the outcome of the migration. | Module | Total Accounts | Total stake to unlock | Total deposit to unreserve | | ------- | --------------- | --------------------- | -------------------------- | | Elections Phragmen | 27 | 1,132.821063320441 ROC | 1.465386531600 ROC | | Democracy | 69 | 2733.923509345613 ROC | 0.166666665000 ROC | | Tips | 4 | N/A | 0.015099999849 ROC | The migrations will also remove the following amount of keys 103 Democracy keys 🧹 5 Council keys 🧹 1 TechnicalCommittee keys 🧹 25 PhragmenElection keys 🧹 1 TechnicalMembership keys 🧹 9 Tips keys 🧹

Polkadot-Forum · 2023-11-15T11:00:19Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-3-0/4614/1

opengov rococo westend

9485f9c

al3mart added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Aug 25, 2023

al3mart requested review from joepetrowski, mordamax and muharem August 25, 2023 16:10

al3mart self-assigned this Aug 25, 2023

gilescope added 2 commits September 3, 2023 15:19

Merge branch 'master' into al3mart/opengov-rococo-westend

76cdae9

cargo fmt & toml sort after fixing merge conflicts

7da4e7c

gilescope reviewed Sep 6, 2023

View reviewed changes

polkadot/runtime/rococo/src/governance/tracks.rs Outdated Show resolved Hide resolved

gilescope reviewed Sep 6, 2023

View reviewed changes

polkadot/runtime/westend/constants/src/lib.rs Outdated Show resolved Hide resolved

gilescope approved these changes Sep 6, 2023

View reviewed changes

al3mart added 2 commits September 7, 2023 17:33

remove *mint/mine naming in favor of asset_hub

f3261b2

reduce track periods

32054bd

chevdor approved these changes Sep 8, 2023

View reviewed changes

Merge branch 'master' into al3mart/opengov-rococo-westend

ac8096e

liamaharon reviewed Sep 11, 2023

View reviewed changes

liamaharon mentioned this pull request Sep 18, 2023

Cleanup Westend & Rococo Gov V1 storage #1618

Closed

al3mart added 2 commits September 26, 2023 14:21

merge master

2ed2251

std must propagate to sp-arithmetic

46e3ac7

al3mart enabled auto-merge (squash) September 26, 2023 12:38

bump spec version

51212d4

al3mart added 3 commits September 26, 2023 15:15

bump

c1c66a6

add referenda migration

1646ba4

correct spec versions

feb41f1

al3mart added 2 commits September 27, 2023 14:29

referenda migrations

d959802

correct instance

a9474a6

al3mart merged commit 69ed308 into master Sep 27, 2023

al3mart deleted the al3mart/opengov-rococo-westend branch September 27, 2023 14:37

al3mart mentioned this pull request Oct 11, 2023

Adding migrations to clean Rococo Gov 1 storage & reserved funds #1849

Merged

kiltbot mentioned this pull request Nov 7, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.2.0 to 1.3.0 KILTprotocol/kilt-node#575

Closed

albertov19 mentioned this pull request Nov 27, 2023

New Westend/Rococo runtimes not allowing polkadotXcm.send from Reg Accounts #2512

Closed

bkchr pushed a commit that referenced this pull request Apr 10, 2024

fix checks order when registering parachain (#1177)

e5b5679

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenGov in Westend and Rococo#1177

OpenGov in Westend and Rococo#1177
al3mart merged 14 commits intomasterfrom
al3mart/opengov-rococo-westend

al3mart commented Aug 25, 2023 •

edited

Loading

Uh oh!

al3mart commented Aug 25, 2023 •

edited

Loading

Uh oh!

gilescope commented Sep 4, 2023 •

edited

Loading

Uh oh!

al3mart commented Sep 4, 2023

Uh oh!

Uh oh!

Uh oh!

al3mart commented Sep 7, 2023

Uh oh!

chevdor left a comment

Uh oh!

liamaharon left a comment

Uh oh!

mordamax commented Sep 18, 2023

Uh oh!

paritytech-cicd-pr commented Sep 26, 2023

Uh oh!

al3mart commented Sep 27, 2023

Uh oh!

Polkadot-Forum commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

al3mart commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

al3mart commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gilescope commented Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

al3mart commented Sep 4, 2023

Uh oh!

Uh oh!

Uh oh!

al3mart commented Sep 7, 2023

Uh oh!

chevdor left a comment

Choose a reason for hiding this comment

Uh oh!

liamaharon left a comment

Choose a reason for hiding this comment

Uh oh!

mordamax commented Sep 18, 2023

Uh oh!

paritytech-cicd-pr commented Sep 26, 2023

Uh oh!

al3mart commented Sep 27, 2023

Uh oh!

Polkadot-Forum commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

al3mart commented Aug 25, 2023 •

edited

Loading

al3mart commented Aug 25, 2023 •

edited

Loading

gilescope commented Sep 4, 2023 •

edited

Loading