Skip to content

wasm-builder: Make it easier to build a WASM binary#4177

Merged
bkchr merged 5 commits intomasterfrom
bkchr-wasm-builder-simplify
Apr 22, 2024
Merged

wasm-builder: Make it easier to build a WASM binary#4177
bkchr merged 5 commits intomasterfrom
bkchr-wasm-builder-simplify

Conversation

@bkchr
Copy link
Member

@bkchr bkchr commented Apr 17, 2024

Basically combines all the recommended calls into one build_using_defaults() call or init_with_defaults() when there are some custom changes required.

Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Apr 17, 2024
@bkchr bkchr requested a review from a team April 17, 2024 13:51
@bkchr bkchr requested a review from koute as a code owner April 17, 2024 13:51
/// .import_memory()
/// .export_heap_base()
/// ```
pub fn init_with_defaults() -> Self {
Copy link
Contributor

@michalkucharczyk michalkucharczyk Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just default?

@bkchr bkchr added this pull request to the merge queue Apr 22, 2024
Merged via the queue into master with commit bd9287f Apr 22, 2024
@bkchr bkchr deleted the bkchr-wasm-builder-simplify branch April 22, 2024 19:56
bkchr added a commit that referenced this pull request May 22, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
bkchr added a commit that referenced this pull request May 22, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
bkchr added a commit that referenced this pull request May 22, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
bkchr added a commit that referenced this pull request May 23, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
bkchr added a commit that referenced this pull request May 24, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
bkchr added a commit that referenced this pull request May 24, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
bkchr added a commit that referenced this pull request May 24, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
bkchr added a commit that referenced this pull request May 24, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
bkchr added a commit that referenced this pull request May 25, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
bkchr added a commit that referenced this pull request May 25, 2024
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T0-node This PR/Issue is related to the topic “node”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants