Not supported evm.bytecode and evm.assembly options in compiler configuration

[smiasojed]

Although the tool claims that it does not support evm.bytecode and evm.assembly, it still returns it as part of the compilation output.

Used compiler config:

{
	"language": "Solidity",
	"settings": {
		"optimizer": {
			"enabled": true,
			"runs": 200
		},
		"outputSelection": {
			"*": {
			"": ["ast"],
			"*": ["abi", "metadata", "devdoc", "userdoc", "storageLayout", "evm.bytecode", "evm.legacyAssembly", "evm.deployedBytecode", "evm.methodIdentifiers", "evm.assembly"]
			}
		}
	}
}

It is expected that tool accepts evm.bytecode and evm.assembly

[smiasojed]

evm.gasEstimates is also not supported

[xermicus]

Stemming from an internal discussion:

• Provide what was requested; however
• Provide default values for incompatible data (if requested)

We substitute any byte-code incompatible fields with empty objects. This won't crash any tools relying on it, they can still request it but will get a zero or empty value. Which they can do nothing with so we should be save. Also this will make remix happy.

[athei]

Both of them should be advertised as being available in order to maximize compatibility.

evm.bytecode should be returned but empty (we only have init code). evm.assembly should contain the PolkaVM dissassembly.

[xermicus]

To me it'd also make sense to just provide the blob for both, the deploy code and runtime code? Because it is the same, it seems like we can just provide both for maximum compatibility.

[athei]

Yeah that would work, too.

[smiasojed]

Remix uses evm.bytecode internally, so I think it is better to keep bytecode in sync with deployedBytecode.

[athei]

Because of course they do. They depend on every little detail :(

[smiasojed]

evm.assembly should contain the PolkaVM dissassembly.

I think that we need to update polkavm-disassembler to be compatible with evm.legacyAssembly

"legacyAssembly": 
				{
							".code": [
								{
									"begin": 199,
									"end": 555,
									"name": "PUSH",
									"source": 0,
									"value": "80"
								}
                                                           ]
				}

[xermicus]

Legacy assembly is not to confuse with EVM bytecode. Legacy assembly is technically speaking on of our IRs. It can be passed through as-is.

[smiasojed]

We have in revive

  #[serde(rename = "legacyAssembly")]
    pub assembly: Option<Assembly>,
    /// The contract PolkaVM assembly code.
    #[serde(rename = "assembly")]
    pub assembly_text: Option<String>,

assembly_text (evm.assembly) is updated with polkavm assembly but assembly (evm.legacyAssembly) is still evm assembly

[xermicus]

Ah yeah, assembly_text is custom, it isn't a thing for solc.