This repository was archived by the owner on Nov 15, 2023. It is now read-only.
grandpa: reannounce voted blocks periodically#3602
Merged
Conversation
andresilva
changed the title
Demi-Marie
approved these changes
Sep 12, 2019
andresilva
added a commit
that referenced
this pull request
Sep 17, 2019
* grandpa: reannounce latest voted blocks periodically * grandpa: add test for background block announcement * grandpa: configurable delay for background block announcer * grandpa: nits
andresilva
added a commit
that referenced
this pull request
Sep 17, 2019
* grandpa: reannounce latest voted blocks periodically * grandpa: add test for background block announcement * grandpa: configurable delay for background block announcer * grandpa: nits
Demi-Marie
pushed a commit
to Demi-Marie/substrate
that referenced
this pull request
Sep 17, 2019
* grandpa: reannounce latest voted blocks periodically * grandpa: add test for background block announcement * grandpa: configurable delay for background block announcer * grandpa: nits
en
pushed a commit
to en/substrate
that referenced
this pull request
Sep 24, 2019
* grandpa: reannounce latest voted blocks periodically * grandpa: add test for background block announcement * grandpa: configurable delay for background block announcer * grandpa: nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for GRANDPA to keep progressing it is imperative that nodes sync to all forks that are being voted on, since we cannot process a vote until we import the block it refers to (and it ancestors).
This PR adds a background worker that keeps track of the block hashes of our latest votes and re-announces them through sync when GRANDPA stops progressing. It just keeps a bounded
VecDequeof latest hashes and announces all of them when stalled, without tracking any context of round or set id.