Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fix companion status check by requiring at least 3 approvals #7147

Closed
bkchr wants to merge 1 commit into from
Closed

Fix companion status check by requiring at least 3 approvals #7147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .maintain/gitlab/check_polkadot_companion_status.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ while IFS= read -r line; do
fi
done < companion_pr_reviews_current.json

# Then we check for at least 1 APPROVED
if [ -z "$(jq -r -e '.[].state | select(. == "APPROVED")' < companion_pr_reviews.json)" ]; then
# Then we check for at least 3 approvals
if [ "$(jq -r -e '[.[].state | select(. == "APPROVED")] | length' < companion_pr_reviews.json)" -ge "3" ]; then
boldprint "polkadot pr #${pr_companion} not APPROVED"
exit 1
fi
Expand Down