This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix weight for inner call with new origin#7196
Merged
2 commits merged intomasterfrom Oct 1, 2020
Merged
Conversation
gui1117
force-pushed
the
gui-fix-inner-call-weight
branch
from
9f0731e to
fd367ba
Compare
gui1117
added
B7-runtimenoteworthy
C1-low
shawntabrizi
approved these changes
Sep 24, 2020
Member
shawntabrizi
left a comment
shawntabrizi
left a comment
There was a problem hiding this comment.
This makes sense, but will be an overestimation since not all extrinsics may actually modify the user's account.
I wonder if there is a better long term solution that would lead to more accurate measurements.
Contributor
Author
|
I guess we also need update the weight files in runtime, and maybe also default ones ? I would be find just updating weight on new release for both substrate and polkadot, but updating node-runtime weight would allow to see how weights evolve. |
bkchr
approved these changes
Oct 1, 2020
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
liuchengxu
pushed a commit
to liuchengxu/substrate
that referenced
this pull request
Oct 5, 2020
* fix weight for inner call with new origin * fix
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inner call with different origin expect their origin accountdata to be already read and write by transaction nonce update. Thus we have to take this into account when it is actually not the case