This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix on_runtime_upgrade weight recording#7480
Merged
shawntabrizi merged 5 commits intomasterfrom Nov 3, 2020
Merged
Conversation
shawntabrizi
added
A0-please_review
13 tasks
bkchr
approved these changes
Nov 3, 2020
apopiak
reviewed
Nov 3, 2020
Contributor
|
resolves #7427 |
darkfriend77
pushed a commit
to mogwaicoin/substrate
that referenced
this pull request
Jan 11, 2021
* Fix on_runtime_upgrade weight recording * fix naming * Update lib.rs * fix line width * fix line width again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
frame_executive/frame_systemwhere the weight of runtime upgrade logic was not represented in the block.The issue arises from the following steps:
on_runtime_upgradelogic (which updates weight)This both fixes the bug and optimizes the code such that the weight is locally tracked during the entirety of the
initialize_block_impl, and only one storage write is used to update that weight at the end of the function.This also takes into account the weight of
frame_systemon_initializeweight, which does not exist right now, but could later.A test has been added that verifies all weights being tracked in the
initialize_block_implare being recorded correctly.