This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Rename system_networkState to system_unstable_networkState#8001
Merged
1 commit merged intoparitytech:masterfrom Feb 2, 2021
Merged
Rename system_networkState to system_unstable_networkState#80011 commit merged intoparitytech:masterfrom
1 commit merged intoparitytech:masterfrom
Conversation
tomaka
added
A0-please_review
bkchr
approved these changes
Jan 28, 2021
Contributor
|
@maciejhirsz Does Telemetry use this one? |
Contributor
Author
|
Nodes send this "network state" to the telemetry, which then shows it in the UI. |
Contributor
Author
|
Could someone else approve this PR? |
romanb
approved these changes
Feb 2, 2021
Contributor
Author
|
Thanks! |
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames this JSON-RPC function in order to make it clear that has never been intended to be stable nor long-term.
This is a breaking change. If you had an automatic script that is using
system_networkState, which you weren't supposed to do in the first place, then it will break.If you were using this function to get the local PeerId and listened addresses, then I invite you to use
system_localPeerIdandsystem_localListenAddressesinstead.cc paritytech/polkadot-sdk#558