Skip to content

Refactor: extract functions and types for creating extrinsics#138

Merged
ascjones merged 10 commits intomasterfrom
aj-offline-signing
Jul 20, 2020
Merged

Refactor: extract functions and types for creating extrinsics#138
ascjones merged 10 commits intomasterfrom
aj-offline-signing

Conversation

@ascjones
Copy link
Contributor

@ascjones ascjones commented Jul 6, 2020

Extracts the types and routines for creating extrinsics from the client so they can be used independently of the Client to construct extrinsics.

todo

  • Sense check public API.

@ascjones ascjones changed the title Extract functions and types for creating extrinsics Refactor: extract functions and types for creating extrinsics Jul 6, 2020
@ascjones ascjones requested a review from Demi-Marie July 15, 2020 10:00
@ascjones
Copy link
Contributor Author

@niklasad1 I think remember you asking a while ago in Riot about constructing extrinsics offline - maybe this PR would be useful. /cc @dvdplm

@ascjones ascjones marked this pull request as ready for review July 15, 2020 10:02
@ascjones ascjones merged commit cd6b8f4 into master Jul 20, 2020
@ascjones ascjones deleted the aj-offline-signing branch July 20, 2020 08:17
async-std = { version = "=1.5.0", features = ["attributes"] }
env_logger = "0.7.1"
wabt = "0.9.2"
wabt-sys = "=0.7.1" # pinned because 0.7.2 fails to compile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reported against wabt-sys.

@ascjones ascjones mentioned this pull request Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants