Workaround for pallet missing declare error type#259
Closed
jasl wants to merge 1 commit into
Closed
Conversation
jasl
force-pushed
the
workaround-missing-error-metadata
branch
from
e679eaf to
c355ad0
Compare
jasl
force-pushed
the
workaround-missing-error-metadata
branch
from
c355ad0 to
9d75942
Compare
Contributor
Author
|
Ops... seems CI failure not my mistake |
Contributor
|
We can close it since #294 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref Substrate issue paritytech/substrate#8501
I'd like fix that issue, but I think subxt still need to do a workaround because it would crash inside subxt.
In short,
when pallet missing declare Error type, the errors field in metadata will be empty,
then, if Subxt parsing block meets error which not list in metadata, it will trigger https://github.com/paritytech/substrate-subxt/blob/master/src/metadata.rs#L256
then, it will crash inside Subxt