ci: Add support for Xcode 16#1818
Merged
Merged
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1818 +/- ##
===========================================
+ Coverage 64.24% 82.80% +18.56%
===========================================
Files 201 282 +81
Lines 23233 30726 +7493
===========================================
+ Hits 14926 25443 +10517
+ Misses 8307 5283 -3024 ☔ View full report in Codecov by Sentry. |
mtrezza
reviewed
Oct 30, 2024
Member
mtrezza
left a comment
There was a problem hiding this comment.
Nice! What happened to the tests (build:starters) though?
Member
Author
|
Xcode 14, 15, 16 runs |
Member
|
Oh, now I saw it in the changes. I'll add that to the TODOs |
mtrezza
reviewed
Oct 30, 2024
Member
|
I feel like this deserves a changelog entry. Normally, when we add support for a platform version, we have a changelog entry, but the README does not state any specific IDE or OS compatibility. It says iOS 12 for example, but what should that mean? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
CI is currently not testing with Xcode 16.
Closes: #1812
Closes: #1799
Approach
TODOs before merging