Skip to content

Dispatch better disconnect events #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhansche merged 4 commits into from
Mar 29, 2017
Merged

Dispatch better disconnect events #39

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c607a17
Fix #38 by sending a proper close() status code
Mar 28, 2017
b6a5fd2
Add userInitiated boolean to the on-disconnected callback
Mar 28, 2017
acd04c1
Dispatch onDisconnected after a socket error
Mar 28, 2017
8481649
Fix CR comments
Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix CR comments
  • Loading branch information
Joe Hansche committed Mar 28, 2017
commit 8481649018a59c6183e4aaeac4bdbd74e5ee6ed6
5 changes: 2 additions & 3 deletions ParseLiveQuery/src/test/java/com/parse/TestParseLiveQueryClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ public void testDisconnectOnBackgroundThread() throws Exception {
}

@Test
public void testCallbackNotifiedOnDisconnect() throws Exception {
public void testCallbackNotifiedOnUnexpectedDisconnect() throws Exception {
LoggingCallbacks callbacks = new LoggingCallbacks();
parseLiveQueryClient.registerListener(callbacks);
callbacks.transcript.assertNoEventsSoFar();
Expand All @@ -410,9 +410,8 @@ public void testCallbackNotifiedOnDisconnect() throws Exception {
callbacks.transcript.assertEventsSoFar("onLiveQueryClientDisconnected: false");
}


@Test
public void testCallbackNotifiedOnDisconnect_expected() throws Exception {
public void testCallbackNotifiedOnExpectedDisconnect() throws Exception {
LoggingCallbacks callbacks = new LoggingCallbacks();
parseLiveQueryClient.registerListener(callbacks);
callbacks.transcript.assertNoEventsSoFar();
Expand Down