Skip to content
This repository was archived by the owner on Jan 16, 2021. It is now read-only.
/ ParseUI-iOS Public archive

Define PFLocalizedString, avoiding re-mapping NSLocalizedString macro.#193

Merged
nlutsenko merged 1 commit intoparse-community:masterfrom
huguesbr:PFLocalizedString
Nov 4, 2015
Merged

Define PFLocalizedString, avoiding re-mapping NSLocalizedString macro.#193
nlutsenko merged 1 commit intoparse-community:masterfrom
huguesbr:PFLocalizedString

Conversation

@huguesbr
Copy link
Contributor

@huguesbr huguesbr commented Nov 4, 2015

No description provided.

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 4, 2015

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@nlutsenko
Copy link
Contributor

nlutsenko commented Nov 4, 2015

Awesome! Will merge in after CLA is signed and Travis passes.

@nlutsenko nlutsenko self-assigned this Nov 4, 2015
@nlutsenko nlutsenko added this to the 1.1.7 milestone Nov 4, 2015
@nlutsenko
Copy link
Contributor

nlutsenko commented Nov 4, 2015

Ok, great. Travis passed, the last piece is CLA - please sign it, so I can merge it in.

@huguesbr
Copy link
Contributor Author

huguesbr commented Nov 4, 2015

@nlutsenko for my education what is CLA?
edited: never mind.. I've just learn to read.. :)

@huguesbr
Copy link
Contributor Author

huguesbr commented Nov 4, 2015

@nlutsenko CLA done.. I hope I didn't just offer my very first born (or second, I already have a daughter...)

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 4, 2015

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

nlutsenko added a commit that referenced this pull request Nov 4, 2015
@nlutsenko
Merge pull request #193 from huguesbr/PFLocalizedString
d17d821 
Define PFLocalizedString, avoiding re-mapping NSLocalizedString macro.
@nlutsenko nlutsenko merged commit d17d821 into parse-community:master Nov 4, 2015
@nlutsenko nlutsenko mentioned this pull request Nov 18, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed GH Review: accepted

Projects

None yet

Milestone

1.1.7

Development

Successfully merging this pull request may close these issues.

3 participants

@huguesbr @facebook-github-bot @nlutsenko