fix: remove custom flattening for otel logs#1019
Merged
nitisht merged 3 commits intoDec 6, 2024
Merged
Conversation
with generic flattening in place, server doesn't need to perform custom flattening for the otel logs client does not need to send additional header `X-P-Log-Source=OTEL` for API `/v1/logs` which is specifically used for otel log ingestion no custom logic is required to verify if header `X-P-Log-Source` is sent no custom flattening is required either server does the flattening if it finds the nested structure and ingests
nikhilsinhaparseable
force-pushed
the
otel-flattening-changes
branch
from
4a403d7 to
2e9821b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with generic flattening in place,
server doesn't need to perform custom flattening for the otel logs client does not need to send additional header
X-P-Log-Source=OTELfor API
/v1/logswhich is specifically used for otel log ingestion-no custom logic is required to verify if header
X-P-Log-Sourceis sent-no custom flattening is required either
-server does the flattening if it finds the nested structure and ingests