feat: ffmpeg CLI fallback for MKV/WebM/OGG support#22
Merged
Conversation
What: 3-tier audio loading fallback: AVAudioFile → AVAsset → ffmpeg CLI. New FFmpegHelper enum handles binary detection (cached via static let, searches FFMPEG_BINARY env → /opt/homebrew/bin → /usr/local/bin → ~/.local/bin → /usr/bin) and audio extraction to 16kHz mono WAV. AudioMixer.loadAudioAsFloat32() now catches AVAsset failures and falls back to ffmpeg. New error cases: .ffmpegNotAvailable, .ffmpegFailed.
File picker dynamically adds MKV/WebM/OGG when FFmpegHelper.isAvailable. Settings → About shows ffmpeg status (green checkmark or grey "Not installed").
Tests detection, UTType registration, error descriptions, and audio extraction from MKV/WebM (XCTSkip when ffmpeg not installed).
Replace on-the-fly ffmpeg conversion in tests with pre-built fixtures: - sine_440hz_48k.mkv (H264 + AAC, 2ch, 48kHz) - sine_440hz_48k.webm (VP9 + Opus, 2ch, 48kHz) - sine_440hz_48k.ogg (Vorbis, 2ch, 48kHz) Tests now cover all three formats individually, full fallback chain for MKV and WebM, and energy verification. All XCTSkip when ffmpeg not installed.
pasrom
force-pushed
the
feat/ffmpeg-fallback
branch
from
f96ade4 to
07564a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FFmpegHelperdetects ffmpeg binary via env var / common paths, cached at first accessTest plan
FFmpegHelperTests(detection, error descriptions, MKV/WebM/OGG loading, fallback chain, energy check, duration comparison)