fix(app): use actual sample rate for mix instead of hardcoded 48kHz#24
Merged
fix(app): use actual sample rate for mix instead of hardcoded 48kHz#24
Conversation
The output device rate can differ from 48kHz (e.g. 24kHz when
meeting-simulator plays 16kHz fixtures via AVAudioPlayer). The mix
was always saved at 48kHz regardless of the actual capture rate,
causing 2x playback speed ("Mickey Mouse" audio).
Fix: use actualSampleRate from AudioCaptureSession for the mix WAV
header. Remove unnecessary in-memory resampling of app/mic samples
in DualSourceRecorder.stop() — the pipeline resamples to 16kHz later.
Also simplify AppAudioCapture rate handling: query rate after device
start, accept whatever CoreAudio reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output device rate can differ from 48kHz (e.g. 24kHz when meeting-simulator plays 16kHz fixtures via AVAudioPlayer). The mix was always saved at 48kHz regardless of the actual capture rate, causing 2x playback speed ("Mickey Mouse" audio).
Fix: use actualSampleRate from AudioCaptureSession for the mix WAV header. Remove unnecessary in-memory resampling of app/mic samples in DualSourceRecorder.stop() — the pipeline resamples to 16kHz later. Also simplify AppAudioCapture rate handling: query rate after device start, accept whatever CoreAudio reports.