refactor(app): use macOS Keychain for secret storage#27
Merged
Conversation
pasrom
force-pushed
the
refactor/keychain-secrets
branch
from
3b981fc to
3a804cd
Compare
What: Replace file-based secret storage with Security.framework (SecItemAdd/CopyMatching/Update/Delete). Reasoning: - Problem: Plaintext files in ~/.secrets/ are not allowed in App Sandbox and fail Mac App Store review - Decision: Use macOS Keychain via Security.framework with service name from AppPaths.logSubsystem. Same API surface (save/read/delete/ exists) so no caller changes needed.
pasrom
force-pushed
the
refactor/keychain-secrets
branch
from
5530174 to
c9fb1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.secrets/with POSIX 600 permissions) with macOS Keychain via Security.frameworkSecItemAdd,SecItemCopyMatching,SecItemUpdate,SecItemDeletewith service namecom.meetingtranscribersave/read/delete/exists) — no changes needed in callers (AppSettings)Test plan
swift buildcompilesswift test— all 491 tests pass (including KeychainHelperTests)./scripts/lint.sh— 0 violations