refactor(app): use sandbox-compatible paths in AppPaths#28
Merged
Conversation
What: Replace hardcoded home-relative paths with FileManager.urls API. Reasoning: - Problem: Hardcoded ~/Library/... and ~/.meeting-transcriber/ paths break inside an App Sandbox container - Decision: Use FileManager.urls(for:in:) which automatically resolves to the sandbox container path when sandboxed, same path otherwise. Move ipcDir under dataDir instead of a separate dotdir in $HOME.
Without migration, the app loses track of previously processed recordings when ipcDir moves to dataDir/ipc, causing old recordings to be re-queued through the pipeline. Uses try/catch with specific CocoaError cases instead of fileExists guards to avoid TOCTOU. Logs migration success/failure.
pasrom
force-pushed
the
refactor/sandbox-paths
branch
from
3471e35 to
c2ddd09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
homeDirectoryForCurrentUser-based paths withFileManager.urls(for:in:)APIdataDirnow usesapplicationSupportDirectorywhich automatically resolves to the sandbox container pathipcDirunderdataDir/ipcinstead of~/.meeting-transcriber/(no longer needs a separate dotdir in $HOME)homepropertyTest plan
swift buildcompilesswift test— all 491 tests pass./scripts/lint.sh— 0 violations