Skip to content

fix(app): fix menu bar icon staying inactive during file processing#43

Merged
pasrom merged 2 commits intomainfrom
fix/menu-bar-icon-inactive-state
Mar 18, 2026
Merged

fix(app): fix menu bar icon staying inactive during file processing#43
pasrom merged 2 commits intomainfrom
fix/menu-bar-icon-inactive-state

Conversation

@pasrom
Copy link
Copy Markdown
Owner

@pasrom pasrom commented Mar 18, 2026

Problem

The menu bar icon stayed .inactive in two cases:

  1. File processing — no watchLoop exists, so currentBadge never checked the pipeline queue
  2. State transitions — the timer guard (guard currentBadge.isAnimated) stopped ticking, so the icon could get stuck when transitioning from inactive to an active state

Fix

  • currentBadge now checks pipelineQueue.activeJobs independently of watchLoop
  • Timer always ticks every 0.4s — non-animated badges return cached frame 0, so there's no visual cost

Test plan

  • Open file via "Process Audio/Video Files..." → icon animates during transcribing/diarizing/protocol
  • Start manual recording via "Record App..." → icon shows recording animation immediately
  • Icon transitions correctly between all states without getting stuck

Two issues:
1. currentBadge only checked watchLoop states, so icon stayed idle
   when files were processed directly (no watchLoop active).
   Fix: check pipelineQueue.activeJobs independently of watchLoop.

2. Timer guard stopped ticking when badge was not animated, so icon
   could get stuck on .inactive during state transitions.
   Fix: always tick — non-animated badges ignore animationFrame anyway.
@github-actions github-actions bot added the bug Something isn't working label Mar 18, 2026
@pasrom pasrom merged commit f903a53 into main Mar 18, 2026
6 checks passed
@pasrom pasrom deleted the fix/menu-bar-icon-inactive-state branch March 18, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant