fix(app): fix menu bar icon staying inactive during file processing#43
Merged
fix(app): fix menu bar icon staying inactive during file processing#43
Conversation
Two issues: 1. currentBadge only checked watchLoop states, so icon stayed idle when files were processed directly (no watchLoop active). Fix: check pipelineQueue.activeJobs independently of watchLoop. 2. Timer guard stopped ticking when badge was not animated, so icon could get stuck on .inactive during state transitions. Fix: always tick — non-animated badges ignore animationFrame anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The menu bar icon stayed
.inactivein two cases:watchLoopexists, socurrentBadgenever checked the pipeline queueguard currentBadge.isAnimated) stopped ticking, so the icon could get stuck when transitioning from inactive to an active stateFix
currentBadgenow checkspipelineQueue.activeJobsindependently ofwatchLoopTest plan