fix(app): mark recording as processed when job fails#46
Merged
Conversation
Start Watching button showed 'Stop Watching' during manual recording because isWatching only checked isActive. It now also requires isManualRecording == false.
…covery Failed jobs were not calling markProcessed, so their recording files remained untracked. Starting Watch mode would recover and re-queue them via recoverOrphanedRecordings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Failed jobs did not call
markProcessed, so their recording files remained untracked on disk. When pressing "Start Watching" afterwards,recoverOrphanedRecordingspicked them up and re-queued them — causing e.g. a "Empty transcript" error to be retried endlessly.Fix
updateJobStatenow callsmarkProcessedfor both.doneand.errorterminal states.Test
Added
testErrorJobIsMarkedProcessedSoRecoverySkipsItwhich simulates the exact scenario: enqueue → fail → new queue instance must not recover the file.