fix(app): guard against invalid range in applyMuteMask#5
Merged
Conversation
When micDelay exceeds mute timeline timestamps, the clamped range end could be less than start, causing a Range precondition failure. Skip empty/inverted ranges instead of crashing.
Cover the crash scenario: large micDelay producing inverted range, and partial negative range where mute starts before recording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioMixer.applyMuteMaskwhenmicDelayexceeds mute timeline timestampslower..<uppercould havelower > upper, causing a Swift Range precondition failure (EXC_BREAKPOINT)guard lower < upper else { continue }Test plan
AudioMixer.swift:127)