fix(app): improve mic device change handling with testable restart policy#58
Merged
fix(app): improve mic device change handling with testable restart policy#58
Conversation
…licy What: Add AVAudioEngine.configurationChangeNotification observer, preserve selected device UID across restarts, and extract restart logic into a pure MicRestartPolicy function for unit testing. Reasoning: - Problem: Only kAudioHardwarePropertyDefaultInputDevice was monitored, missing format/route changes. Restart logic (reentrancy guard, device fallback) was untestable without hardware. - Approach: "Functional Core, Imperative Shell" — pure decision function takes state as input, returns action enum. MicCaptureHandler becomes thin shell that calls policy + executes CoreAudio/AVAudioEngine ops. - Add deinit safety net, isRestarting guard, isRecording=false on error. - 8 unit tests cover all decision paths without mocks or hardware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AVAudioEngine.configurationChangeNotificationobserver to catch format/route changes (not just default device changes)MicRestartPolicy.decideRestart()function (Functional Core, Imperative Shell)isRestarting),deinit { stop() }safety net,isRecording = falseon restart failurelistenerInstalledstate (replaced bydeviceChangeListener != nil)MicRestartPolicy(first tests in AudioTapLib)Test plan
swift testpasses (745 app tests + 8 AudioTapLib tests)./scripts/lint.shpasses (0 violations)