Skip to content

feat(app): configurable protocol output language#62

Merged
pasrom merged 2 commits intomainfrom
feat/protocol-language
Mar 22, 2026
Merged

feat(app): configurable protocol output language#62
pasrom merged 2 commits intomainfrom
feat/protocol-language

Conversation

@pasrom
Copy link
Copy Markdown
Owner

@pasrom pasrom commented Mar 22, 2026

Summary

Inspired by execsumo/meeting-transcriber (commits fae3632, 0adb1f8).

Replace hardcoded "in German" in the protocol prompt with a configurable language setting.

  • New protocolLanguage setting (default: German) with 22 language options
  • {LANGUAGE} template in the built-in prompt, substituted at runtime via applyLanguage()
  • Custom prompts also get {LANGUAGE} replaced if the placeholder is present
  • Language picker in Settings under Protocol Generation section
  • Both ClaudeCLI and OpenAI generators receive the language at init time

Changes

  • AppSettings.swift: protocolLanguage property + protocolLanguages list
  • ProtocolGenerator.swift: {LANGUAGE} template + applyLanguage() method
  • ClaudeCLIProtocolGenerator.swift: language stored property, applied in generate()
  • OpenAIProtocolGenerator.swift: language stored property, applied in generate()
  • AppState.swift: Pass settings.protocolLanguage to generator factories
  • SettingsView.swift: Protocol Language picker

Test plan

  • 3 new tests for applyLanguage() (replace, passthrough, placeholder exists)
  • Existing prompt test updated ("German""{LANGUAGE}")
  • Full suite: 770 tests, 0 failures
  • Lint: 0 violations
  • AppStore build variant: OK

pasrom added 2 commits March 22, 2026 18:33
Replace hardcoded "in German" in the protocol prompt with a {LANGUAGE}
template. New protocolLanguage setting (default: German) with 22
language options. Picker in Settings under Protocol Generation.
Both ClaudeCLI and OpenAI generators apply the language substitution.
Custom prompts also get {LANGUAGE} replaced if present.
@github-actions github-actions bot added the enhancement New feature or request label Mar 22, 2026
@pasrom pasrom merged commit 20c4c8d into main Mar 22, 2026
7 checks passed
@pasrom pasrom deleted the feat/protocol-language branch March 22, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant